Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in createOrUpdateStagingDeploy #3815

Merged
merged 8 commits into from
Jul 7, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jun 29, 2021

Details

This is really just a test for the problem described here, and we're adding a log line to see if it can help trace the bug.

Furthermore, the NPM_VERSION input is not passed when we're adding a new deploy blocker, because that value hasn't changed. However, we don't want to add any new PRs to the main list (certainly not any very old ones like we saw in the linked checklist here. So when that input is missing, use the tag of the current issue to generate the PR list.

In addition, I created a separate method to fetch a list of pull requests which can be reused in the future.

Fixed Issues

n/a - see linked comment above.

Tests

  1. Unlock the StagingDeployCash
  2. Merge this PR.
  3. It should be added to the checklist, but (hopefully) no other long list of old PRs will be added. If they are, at least we'll have better logs.
  4. Label it DeployBlockerCash.
  5. It should be added to the checklist under the deploy blocker section, but the checklist should be otherwise unchanged.

QA Steps

None.

Tested On

n/a – GitHub only.

@roryabraham roryabraham self-assigned this Jun 29, 2021
@roryabraham roryabraham requested a review from a team as a code owner June 29, 2021 23:40
@MelvinBot MelvinBot requested review from tylerkaraszewski and removed request for a team June 29, 2021 23:40
@roryabraham roryabraham changed the title Add log line for npm_version in createOrUpdateStagingDeploy Fix bugs in createOrUpdateStagingDeploy Jun 30, 2021
@roryabraham
Copy link
Contributor Author

@tylerkaraszewski Friendly bump please 🙃

Also, just FYI - I advise you ignore any files called index.js in this PR. They are compiled files, and will look like a lot of duplicate code. In reality, they are just Node.js scripts which have been bundled with their dependencies using ncc

@tylerkaraszewski
Copy link
Contributor

Approved but I haven't tested it. I think I'll leave that to whoever's deploying e.cash unless someone really wants me to do it.

@roryabraham
Copy link
Contributor Author

Thanks @tylerkaraszewski, I can test this myself.

@roryabraham roryabraham merged commit f5c9b21 into main Jul 7, 2021
@roryabraham roryabraham deleted the Rory-FixStagingDeployCashPagination branch July 7, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants