-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs in createOrUpdateStagingDeploy #3815
Conversation
@tylerkaraszewski Friendly bump please 🙃 Also, just FYI - I advise you ignore any files called |
Approved but I haven't tested it. I think I'll leave that to whoever's deploying e.cash unless someone really wants me to do it. |
Thanks @tylerkaraszewski, I can test this myself. |
Details
This is really just a test for the problem described here, and we're adding a log line to see if it can help trace the bug.
Furthermore, the
NPM_VERSION
input is not passed when we're adding a new deploy blocker, because that value hasn't changed. However, we don't want to add any new PRs to the main list (certainly not any very old ones like we saw in the linked checklist here. So when that input is missing, use the tag of the current issue to generate the PR list.In addition, I created a separate method to fetch a list of pull requests which can be reused in the future.
Fixed Issues
n/a - see linked comment above.
Tests
StagingDeployCash
DeployBlockerCash
.QA Steps
None.
Tested On
n/a – GitHub only.